PC-1731: Fix variations in text conveying information #361
Conversation
apply the govuk bold class where class is unspecified, to ensure it's consistently styled
| @@ -7,18 +7,18 @@ | |||
| @if (Model.GetCurrentPropertyRecommendation().Key != RecommendationKey.InstallHeatPump) | |||
| { | |||
| <div class="govuk-grid-column-full sea-yearly-savings govuk-!-margin-bottom-2"> | |||
| <span class="govuk-heading-s govuk-!-margin-bottom-0"><b>@SharedLocalizer["This could save up to"]</b></span> | |||
| <span class="govuk-heading-s govuk-!-margin-bottom-0"><strong class="govuk-!-font-weight-bold">@SharedLocalizer["This could save up to"]</strong></span> | |||
There was a problem hiding this comment.
We need the govuk-!-font-weight-bold class as well here?
There was a problem hiding this comment.
I agree, though I think looking back on this it's more natural to copy the other similar instances and make the parent <strong> and remove the inner tag entirely
There was a problem hiding this comment.
Oh, this was a question rather than a statement
There was a problem hiding this comment.
ah sorry, I agree with that we don't need the class on the inner element, though opted to remove the inner element entirely.
for what its worth, I don't think in any case I've checked so far the govuk class has a noticeable impact on the text styling. <strong> by itself seems to be styled. I include it only as GDS signposts this as the way to make text bold
There was a problem hiding this comment.
Might be worth digging into a bit. I'd vote for not having the class unless there's a particular reason for it (on top of <strong>)
remove some nested b tags and make the parent strong instead
Link to Jira ticket
Description
Replace b and non-specific span tags throughout the app
Note GDS does not explicitly recommend using the strong tag, prefering the use of the
govuk-!-font-weight-boldclass. Where no classes are specified, I've added the GDS one to ensure semantic HTML and correct stylingChecklist
Screenshots