Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPL-466c - more unit test updates #285

Merged
merged 7 commits into from
Nov 18, 2024
Merged

SPL-466c - more unit test updates #285

merged 7 commits into from
Nov 18, 2024

Conversation

lambley
Copy link
Collaborator

@lambley lambley commented Nov 11, 2024 •
edited
Loading

Total line coverage increased to 70.38% (from 61.67%)

  • Exclude assets JS files - these should be tested via Playwright suite
  • Increase accessible-planner filters.js coverage to 100%
  • weekUtils
  • hidden-fields macro filters

devind-ra
devind-ra approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@devind-ra devind-ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lambley lambley merged commit 68f4284 into master Nov 18, 2024
5 checks passed
@lambley lambley deleted the RST-466c branch November 18, 2024 11:43
@lambley lambley restored the RST-466c branch November 18, 2024 11:44
@lambley lambley deleted the RST-466c branch November 18, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devind-ra devind-ra devind-ra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lambley @devind-ra