DO NOT MERGE: test #116
Closed
DO NOT MERGE: test #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of consortia to user model. Contains further documentation to make it clear that full Consortia and Local Authority Data is located in the HUG2 Public site codebase.
… codes will require mapping or migrations to ensure correct relationships are maintained
…o improve comment usability.
…te-to-support-consortium-admin-model PC-1083: Adds migration and new model for consortium data. Adds a lis…
dont add the filtered LAs if in a consortium remove LAs when adding the consortium theyre in
it didn't seem to do anything removed the consortium counterpart as well
…an codes including custodian codes of all consortiums they administrate. Updated usages of original user's custodian codes to new method. Updated data access provider to include the user's consortiums when retrieving information from the DB. Updated tests to account for consortiums being included.
when knowing the consortium name is useful for the special exceptions
previously would always use the more complex method
…new custodian code retrieval. Removed unnecessary functions. Removed having all LAs in a consortium giving user Custodian admin rights.
a bit more sensible as this outcome is a bit more unusual
also add a wrapper for confirming database changes
introduce a new CommandHandler class that does the printing and has a public method for each command AdminAction now interfaces with the objects and calls database methods
rename it to UserAccountStatus as UserStatus is quite broad also specify what enum DisplayUserStatus expects
…w function to replace commonly used Consortium to list of string logic. Renamed variables to bring them in line with standard.
Changed TransformFileDataForConsortia to not mutate the passed list. Standardised consortium code security checking to work the same for LA and Consortia.
rename CommandException to CouldNotFindAuthorityException
…m-admin-model-into-business-logic PC-1084 build consortium admin model into business logic
…-update-user-management-scripts-to-onboard-consortium-admins
…agement-scripts-to-onboard-consortium-admins PC-1085 Update user management scripts to onboard consortium admins
duplicate WithConsortia method added by both of us error test output not updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.