-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PC-1057: Implementing the Local Authority single source of truth #121
PC-1057: Implementing the Local Authority single source of truth #121
Conversation
… from LA code to consortium code. Added Worcestershire as an LA.
987e324
to
a982ce0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the new LA to populate_custodian_codes.sql
please? We'll need to run that when we release
/// <see | ||
/// href="https://github.com/UKGovernmentBEIS/desnz-home-energy-retrofit-beta/blob/develop/HerPublicWebsite.BusinessLogic/Models/LocalAuthorityData.cs"> | ||
/// HUG2 Public Website codebase | ||
/// </see> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this autoformatting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It also put it like this:
HUG2
Public Website codebase
as well, but after I pulled the Public Website up a line, it let me keep it there, but would still revert to having the see tag broken up.
Should I leave it as it was originally, with all of the tag and its contents on one line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super bothered. Slight preference for how it was originally, but whatever auto-formatter thinks.
Added Worcestershire to the .sql |
will the names in |
Don't think it's worth the time |
@jdgage I already had the solution just about done, and it exposed that we had lost a legacy LA along the way. (South Somerset) So I've pushed it now. |
Link to Jira ticket
Description
Checklist