Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC-1057: Implementing the Local Authority single source of truth #121

Conversation

Glenn-Clarke
Copy link
Contributor

Link to Jira ticket

Description

  • Updated information in line with the single source of truth document.
  • Updated tests to reflect new information.
  • Added comments to identify Legacy LAs which no longer exist/have been merged with others.

Checklist

  • I have made any necessary updates to the documentation
  • I have checked there are no unnecessary IDE warnings in this PR
  • I have checked there are no unintentional line ending changes
  • I have added tests where applicable
  • If I have made any changes to the code, I have used the IDE auto-formatter on it
  • If I have made any changes to website flow, I have checked forward and back behaviour is still consistent
  • If I have made any changes to the Local Authority or Consortium data, I have made sure these changes have been reflected in the main HUG2 repository

@Glenn-Clarke Glenn-Clarke force-pushed the PC-1057-Implementing-Local-Authority-Single-Source-of-Truth branch from 987e324 to a982ce0 Compare June 13, 2024 14:07
Copy link
Contributor

@jdgage jdgage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the new LA to populate_custodian_codes.sql please? We'll need to run that when we release

Comment on lines +14 to +17
/// <see
/// href="https://github.com/UKGovernmentBEIS/desnz-home-energy-retrofit-beta/blob/develop/HerPublicWebsite.BusinessLogic/Models/LocalAuthorityData.cs">
/// HUG2 Public Website codebase
/// </see>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this autoformatting?

Copy link
Contributor Author

@Glenn-Clarke Glenn-Clarke Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It also put it like this:

HUG2
Public Website codebase

as well, but after I pulled the Public Website up a line, it let me keep it there, but would still revert to having the see tag broken up.

Should I leave it as it was originally, with all of the tag and its contents on one line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super bothered. Slight preference for how it was originally, but whatever auto-formatter thinks.

@Glenn-Clarke
Copy link
Contributor Author

Added Worcestershire to the .sql

@samyou-softwire
Copy link
Contributor

will the names in populate_custodian_codes.sql need to be updated too? as well as names in populate_consortium_codes.sql when that's merged

@jdgage
Copy link
Contributor

jdgage commented Jun 13, 2024

will the names in populate_custodian_codes.sql need to be updated too? as well as names in populate_consortium_codes.sql when that's merged

Don't think it's worth the time

@Glenn-Clarke
Copy link
Contributor Author

@jdgage I already had the solution just about done, and it exposed that we had lost a legacy LA along the way. (South Somerset) So I've pushed it now.

@Glenn-Clarke Glenn-Clarke requested a review from jdgage June 13, 2024 15:53
@Glenn-Clarke Glenn-Clarke merged commit 1edce1a into develop Jun 17, 2024
2 checks passed
@Glenn-Clarke Glenn-Clarke deleted the PC-1057-Implementing-Local-Authority-Single-Source-of-Truth branch June 17, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants