develop -> staging #124
Merged
develop -> staging #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of consortia to user model. Contains further documentation to make it clear that full Consortia and Local Authority Data is located in the HUG2 Public site codebase.
… codes will require mapping or migrations to ensure correct relationships are maintained
…o improve comment usability.
…te-to-support-consortium-admin-model PC-1083: Adds migration and new model for consortium data. Adds a lis…
dont add the filtered LAs if in a consortium remove LAs when adding the consortium theyre in
it didn't seem to do anything removed the consortium counterpart as well
…an codes including custodian codes of all consortiums they administrate. Updated usages of original user's custodian codes to new method. Updated data access provider to include the user's consortiums when retrieving information from the DB. Updated tests to account for consortiums being included.
when knowing the consortium name is useful for the special exceptions
previously would always use the more complex method
…new custodian code retrieval. Removed unnecessary functions. Removed having all LAs in a consortium giving user Custodian admin rights.
a bit more sensible as this outcome is a bit more unusual
Fix GitHub workflow rules
now describes a bit more what it does
…-migrate-historic-data-for-consortium-admins
…-migrate-historic-data-for-consortium-admins
since, by needing to be consortium admin, they own all the LAs
for clarity & comfort to the user
…c-data-for-consortium-admins PC-1086 Migrate historic data for consortium admins
…sortium-admin-role PC-1047 Create a true 'consortium admin' role in the backend
check if the dict contains the key before keying it
PC-1047: fix key error for LAs with no Consortium
references to LAs when adding a consortia will be replaced with Consortia
…codes-script PC-1047: add consortium codes script
…ia-messaging PC-1047: fix add consortia messaging
PC-NONE: Add note about database migrations
jdgage
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.