staging -> main #137
staging -> main #137
Conversation
…ll-las-to-database PC-1363: add script to add all las to database
Dev -> Staging
samyou-softwire
added
the
production release
| if (confirmation) | ||
| adminAction.AddMissingAuthoritiesToDatabase(); | ||
| else | ||
| outputProvider.Output("No changes made."); |
There was a problem hiding this comment.
ifs without braces always make me scared. Any chance we could add some in here?
There was a problem hiding this comment.
linter requirement alas
There was a problem hiding this comment.
🤨
I would turn off that rule in the linter rather than follow it personally. I realise I'm not the actual TL for the project but in my opinion this rule is only leaving yourself open to potential bugs in the future.
There was a problem hiding this comment.
perhaps; the linter rules are not something we've reviewed much before, so can raise a ticket for this. it'd need some work to ensure we're using the same rules for everyone, right now we all agree to use rider's default
can raise a ticket for this
There was a problem hiding this comment.
have done so at https://beisdigital.atlassian.net/browse/PC-1508
There was a problem hiding this comment.
For what it's worth I agree with this
No description provided.