Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drtii 1561 shift performance #2011

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Drtii 1561 shift performance #2011

wants to merge 11 commits into from

Conversation

ngu04
Copy link
Contributor

@ngu04 ngu04 commented Feb 5, 2025

  • moving shift staff-assignments to backend from front to make it performant
  • few minor css changes

ngu04 added 10 commits February 3, 2025 13:04
@ngu04
remove componentDidMount for GetAllStaffShifts
f421b1d 
Signed-off-by: Nilesh Gupta <[email protected]>
@ngu04
making overflow scroll rather auto
fadbb99 
Signed-off-by: Nilesh Gupta <[email protected]>
@ngu04
moving MonthlyShiftsUtil to server side in ShiftsHelper
ee1e343 
Signed-off-by: Nilesh Gupta <[email protected]>
@ngu04
update table fix content
a8ee4d3 
Signed-off-by: Nilesh Gupta <[email protected]>
@ngu04
update table size for shift and staff monthly
a5c2762 
Signed-off-by: Nilesh Gupta <[email protected]>
@ngu04
remove comments
4f949fb 
Signed-off-by: Nilesh Gupta <[email protected]>
@ngu04
moving ShiftSummaryData to separate class
341d32d 
Signed-off-by: Nilesh Gupta <[email protected]>
@ngu04
remove comments
0c7978d 
Signed-off-by: Nilesh Gupta <[email protected]>
@ngu04
shifts-table-content height content
73faa8d 
Signed-off-by: Nilesh Gupta <[email protected]>
@ngu04
put back height for height: 600px;
e1d9a21 
Signed-off-by: Nilesh Gupta <[email protected]>
richbirch
richbirch requested changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@richbirch richbirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things to tidy and names to fix
I'm concerned about moving display logic to the back end. I know you've done this as performance issue fix, but the current staffing page doesn't have this performance issue and it does all the display logic in the front end

server/src/main/scala/controllers/application/ShiftsHelpers.scala Outdated Show resolved Hide resolved
server/src/main/scala/controllers/application/ShiftsController.scala Show resolved Hide resolved
client/src/main/scala/drt/client/services/handlers/ShiftSummaryStaffingHandler.scala Show resolved Hide resolved
server/src/main/scala/controllers/application/ShiftsHelpers.scala Outdated Show resolved Hide resolved
server/src/main/scala/controllers/application/ShiftsHelpers.scala Outdated Show resolved Hide resolved
client/src/main/scala/drt/client/components/ShiftHotTableViewComponent.scala Show resolved Hide resolved
client/src/main/scala/drt/client/services/handlers/ShiftSummaryStaffingHandler.scala Show resolved Hide resolved
client/src/main/scala/drt/client/services/handlers/StaffAssignmentsHandler.scala Outdated Show resolved Hide resolved
client/src/main/scala/drt/client/services/handlers/StaffAssignmentsHandler.scala Outdated Show resolved Hide resolved
server/src/main/scala/controllers/application/ShiftsController.scala Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richbirch richbirch richbirch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngu04 @richbirch