fix: tests ci

Signed-off-by: Pablo Maldonado <[email protected]>
UMAprotocol · Jul 16, 2024 · 9a5c3e2 · 9a5c3e2
1 parent cb52562
commit 9a5c3e2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -25,6 +25,15 @@ jobs:
       - name: "Install Node.js dependencies"
         run: "yarn install"
 
+      - name: "Create .env file"
+        run: |
+          echo 'PROVIDER_URL="https://mainnet.infura.io/v3/00000000000000000000000000000000"' > .env
+          echo 'PROVIDER_WSS="wss://mainnet.infura.io/ws/v3/00000000000000000000000000000000"' >> .env
+          echo 'FORWARD_URL="https://relay.flashbots.net"' >> .env
+          echo 'OVAL_CONFIGS="{\"0x0000000000000000000000000000000000000000\":{\"refundAddress\":\"0x0000000000000000000000000000000000000000\",\"refundPercent\":90,\"unlockerKey\":\"0x0000000000000000000000000000000000000000000000000000000000000000\"}}"' >> .env
+          echo 'AUTH_PRIVATE_KEY="0x0000000000000000000000000000000000000000000000000000000000000000"' >> .env
+          echo 'MAINNET_BLOCK_OFFSET=5' >> .env
+
       - name: "Run the tests"
         run: "yarn test"
 

diff --git a/src/lib/env.ts b/src/lib/env.ts
@@ -1,15 +1,14 @@
 import dotenv from "dotenv";
 import { getAddress, parseEther } from "ethers";
 import { MAINNET_CHAIN_ID, SEPOLIA_CHAIN_ID, fallback, supportedNetworks } from "./constants";
-import { getBoolean, getFloat, getInt, getOvalConfigs, getPrivateKey, getStringArray, isMochaTest } from "./helpers";
+import { getBoolean, getFloat, getInt, getOvalConfigs, getPrivateKey, getStringArray } from "./helpers";
 import { OvalConfigs } from "./types";
 dotenv.config({ path: ".env" });
 
 function getEnvVar(varName: string, defaultValue?: string): string {
   const envValue = process.env[varName];
   if (envValue !== undefined) return envValue;
   if (defaultValue !== undefined) return defaultValue;
-  if (isMochaTest()) return "";
   throw new Error(`Environment error: ${varName} not set.`);
 }
 

diff --git a/src/lib/helpers.ts b/src/lib/helpers.ts
@@ -301,7 +301,7 @@ export function verifyBundleSignature(
 export function getPrivateKey(input: string): string {
   // Prepend 0x if missing.
   const privateKey = input.startsWith("0x") ? input : "0x" + input;
-  if (!isHexString(privateKey, 32) && !isMochaTest()) throw new Error(`Value ${input} not a valid private key`);
+  if (!isHexString(privateKey, 32)) throw new Error(`Value ${input} not a valid private key`);
   return privateKey;
 }