Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dx): make it really clear when OCHA Services is overridden #391

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

rupl
Copy link
Contributor

@rupl rupl commented Feb 19, 2024

I am intentionally leaving the cd-header embed here for the sake of the ticket. See the other PR in CD: UN-OCHA/common_design#463

Refs: CD-537

@left23 review request is FYI only

@rupl rupl requested a review from left23 February 19, 2024 08:29
Copy link

Coverage Report

Totals Coverage

Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.15 (cli) (built: Jan 20 2024 14:17:05) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.15, Copyright (c) Zend Technologies with Zend OPcache v8.2.15, Copyright (c), by Zend Technologies with Xdebug v3.3.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.7.1 2024-02-09 15:26:28
Drupal Logs

Pusher: @rupl, Action: pull_request, Workflow: Run tests

@rupl rupl merged commit e72c21e into develop Feb 19, 2024
2 checks passed
@rupl rupl deleted the updates branch February 19, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant