Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update E2E to match the upcoming change to OCHA Services #394

Merged
merged 6 commits into from
Feb 26, 2024
Merged

test: update E2E to match the upcoming change to OCHA Services #394

merged 6 commits into from
Feb 26, 2024

Conversation

rupl
Copy link
Contributor

@rupl rupl commented Feb 21, 2024 •
edited
Loading

@rupl rupl requested a review from left23 February 21, 2024 09:42
@github-actions GitHub Actions
Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.15 (cli) (built: Jan 20 2024 14:17:05) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.15, Copyright (c) Zend Technologies with Zend OPcache v8.2.15, Copyright (c), by Zend Technologies with Xdebug v3.3.1, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.7.1 2024-02-09 15:26:28
Drupal Logs

Pusher: @rupl, Action: pull_request, Workflow: Run tests

rupl added 2 commits February 21, 2024 11:19
@rupl
chore: rename E2E to eliminate reference to dropdown
3794631 
Refs: CD-537
@rupl
chore: example commit showing how to upgrade OCHA Services
27fb06d 
This will completely do away with the old OCHA Services convention
in a sub-theme, and instead uses the new setup found in CD releases
newer than v9.3.2

Refs: CD-537
@rupl rupl marked this pull request as ready for review February 21, 2024 12:33
@rupl
Copy link
Contributor Author

rupl commented Feb 21, 2024

Whoops! It's not ready yet. It still needs to incorporate a tagged CD release.

@rupl
Copy link
Contributor Author

rupl commented Feb 22, 2024

Ok @left23 this is truly ready for review now.

@rupl
Copy link
Contributor Author

rupl commented Feb 22, 2024

Thanks, I've been trying to put this on the feature environment for Javi to review before I merge it.

@rupl
Copy link
Contributor Author

rupl commented Feb 23, 2024

He asked for one change. Before we deploy I'll wait for that CD PR to land UN-OCHA/common_design#468

@github-actions GitHub Actions
Copy link

Coverage Report

Totals Coverage

@rupl
Copy link
Contributor Author

rupl commented Feb 26, 2024

Javi approved in the ticket. Merging!

@rupl rupl merged commit 065b076 into develop Feb 26, 2024
3 checks passed
@rupl rupl deleted the CD-537 branch February 26, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@left23 left23 left23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rupl @left23