[CD-539] Example to upgrade jest-puppeteer #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strangely the 7 breaking-change involved changing all instances of toMatch() to toMatchTextContent() but it only created errors when that change was implemented and leaving the tests as they were seemed to work fine. Refs: CD-539
Coverage Report
|
Build outputComposer Validate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is the result of:
We went from
5.0.3to10.0.1— the CHANGELOG mentions version 7 having the only breaking change aside from node.js minimum version support: changingtoMatchto betoMatchTextContentWhen I tried to manually change all instances of
toMatchto betoMatchTextContentit resulted in errors. Leaving the tests in their previous state usingtoMatchstill works. I'm unsure why, but I did verify that I'm using the newest version ofjest-puppeteerwhen running commands.