Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: warn and mute command #142
base: main
Are you sure you want to change the base?
Feat: warn and mute command #142
Changes from 25 commits
f91bdc3
3d8ded5
e83c83a
1bea2f0
7c6d00f
5ad7ca1
003656e
95ea13b
ed9b959
5f5a31a
f3c2c9a
f09d904
c7732d1
e7f417b
f0d3625
76022db
4bc2e84
1871ffc
6fa7dae
7d1c699
40c342d
ca26e18
6620ffb
94a0844
7380b9b
af0f98d
f724895
f6b48e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting Filter. It opens quite a few possibilities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on how you implement
warn_time
, but this should probably be a-
andwarn_time < %s
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This job probably gets lost and the user remains muted if, for any reason, the bot gets restarted on the VM.
Just adding a safeguard job running at 5:00 utc could ensure this won't be a problem, but you would have to keep track of the timestamp in a db table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was actually not sure about putting the timedelta in the db table or not, in that case I might as well starting the job_queue on each bot restart rather than checking every day