Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement blacklist #160

Merged
merged 11 commits into from
Feb 25, 2024
Merged

feat: implement blacklist #160

merged 11 commits into from
Feb 25, 2024

Conversation

Helias
Copy link
Member

@Helias Helias commented Feb 21, 2024

blacklist anti-spam

@Helias Helias requested a review from TendTo February 21, 2024 17:59
Copy link
Member

@TendTo TendTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from what I have already commented, I would also add the new feature to the changelog and the new setting parameter to the README, in the Settings section


This said, there are a few considerations I would like to add about the feature itself.
I personally don't really like this kind of heavy-handed moderation. A telegram group already provides all the tools the moderators may use to ban or limit a misbehaving user.

Even worse, I feel like this measure is just going to create more trouble than it solves. Since you are just checking a substring in the message, it would be extremely easy for anyone to avoid the check or, alternately, for an unsuspecting user to see their message deleted just because they used a specific word or expression. Just think about the many asterisks that appear on online chats all the time a word contains any "dangerous" substring. In our case they would just lose the message without any way of recovering it.

I don't know what circumstance made you think of this feature, but I strongly advise against its implementation, especially in the current form.

src/spotted/config/yaml/settings.yaml.types Outdated Show resolved Hide resolved
src/spotted/config/yaml/settings.yaml Outdated Show resolved Hide resolved
src/spotted/handlers/__init__.py Outdated Show resolved Hide resolved
src/spotted/handlers/spam_comment.py Outdated Show resolved Hide resolved
@Helias
Copy link
Member Author

Helias commented Feb 22, 2024

I don't know what circumstance made you think of this feature, but I strongly advise against its implementation, especially in the current form.

I totally agree, it's more an anti-spam feature than a moderation tool, in these days we are experiencing a spam about a telegram channel about a black market that we would like to prevent

I don't think that the user who spams it, is so smart to understand that we are doing this feature and avoid it.

It's only an anti-spam feature, nothing related to the spotted community

@Helias Helias requested a review from TendTo February 25, 2024 11:59
src/spotted/handlers/spam_comment.py Outdated Show resolved Hide resolved
@Helias Helias requested a review from TendTo February 25, 2024 16:30
@TendTo TendTo merged commit f017755 into main Feb 25, 2024
18 checks passed
@TendTo TendTo deleted the blacklist branch February 25, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants