feat:completed risk-risiko #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helias
reviewed
Oct 30, 2023
| print("Giocatore1 ha vinto") | ||
| else: | ||
| print("Giocatore2 ha vinto") | ||
|
|
There was a problem hiding this comment.
potresti implementare qualche funzione
Helias
reviewed
Oct 30, 2023
src/ex6.py
Outdated
Comment on lines
43
to
46
| if counterGiocatore1>=counterGiocatore2: | ||
| print("Giocatore1 ha vinto") | ||
| else: | ||
| print("Giocatore2 ha vinto") |
There was a problem hiding this comment.
qui c'è una ridondanza di codice, potresti salvare in una variabile "winner" il giocatore che vince utiizzando l'operatore ternario e poi scrivere una sola print al posto di scriverne due quasi uguali
Helias
reviewed
Oct 30, 2023
src/ex6.py
Outdated
Comment on lines
28
to
41
| if giocatore1[0]>giocatore2[0]: | ||
| counterGiocatore1+=1 | ||
| else: | ||
| counterGiocatore2+=1 | ||
|
|
||
| if giocatore1[1]>giocatore2[1]: | ||
| counterGiocatore1+=1 | ||
| else: | ||
| counterGiocatore2+=1 | ||
|
|
||
| if giocatore1[2]>giocatore2[2]: | ||
| counterGiocatore1+=1 | ||
| else: | ||
| counterGiocatore2+=1 |
There was a problem hiding this comment.
questo codice è un po' ridondante non credi?
forse creando una funzione potresti ridurre la ridondanza, oppure potresti scriverlo meglio con un ciclo for ed in 3 righe te ne esci ;-)
simone989
reviewed
Oct 31, 2023
|
|
||
| a = int(random()*10) | ||
| b = int(random()*10) | ||
| d = int(random()*10) |
There was a problem hiding this comment.
Definisci una tua funzione random che esegua questa operazione random()*10
simone989
reviewed
Oct 31, 2023
| if giocatore1[2]>giocatore2[2]: | ||
| counterGiocatore1+=1 | ||
| else: | ||
| counterGiocatore2+=1 |
There was a problem hiding this comment.
Aggiungi dei commenti per rendere più chiaro il codice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.