Ex1 #173
Closed
Ex1 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ex1.py
Outdated
Comment on lines
5
to
18
| if week == 1: | ||
| day = "Monday" | ||
| elif week == 2: | ||
| day = "Tuesday" | ||
| elif week == 3: | ||
| day = "Wednesday" | ||
| elif week == 4: | ||
| day = "Thursday" | ||
| elif week == 5: | ||
| day = "Friday" | ||
| elif week == 6: | ||
| day = "Saturday" | ||
| elif week == 7: | ||
| day = "Sunday" |
There was a problem hiding this comment.
invece che usare tutti questi if else, potresti creare un array ordinato di stringhe e accedere direttamente a questo usando come indice il valore intero che la funzione get_week_day riceve in input
There was a problem hiding this comment.
L'esercizio originale richiedeva di costruire la funzione con il costrutto switch, ma la cambio comunque
/* Improve this program using a switch-case. */
There was a problem hiding this comment.
Hai ragione! Colpa mia 😅
Comunque così è molto più carino che con uno switch ahahah
TendTo
requested changes
Nov 8, 2023
TendTo
approved these changes
Nov 8, 2023
simone989
reviewed
Nov 9, 2023
| @@ -0,0 +1,12 @@ | |||
| from src.ex1 import get_week_day | |||
|
|
|||
| def test_ex1() -> None: | |||
There was a problem hiding this comment.
Rinomina correttamente il nome delle funzione
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fatto l'esercizio 1 delle settimane e aggiunto file di test