New Haven Integration and Music Updates for region scp #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strattond
requested changes
Jan 22, 2025
data/dfndata/regions/regions.dfn_old
Outdated
There was a problem hiding this comment.
Unless this is going to be used, I would remove this from the PR - it's not active by this extension
There was a problem hiding this comment.
i left it in like we did the maps file just incase some one wanted to use it, We could just post the information on the boards and remove it. if that be better.
There was a problem hiding this comment.
I'll reiterate what I wrote in a discord PM:
- Rename the file to "regions_old_haven_only.bak"
- Yoink out anything that's not old haven from the file
- Leave a comment at the top of the file stating that this file defines the town region for old haven, which only exists on Trammel facet in client versions 5.0.0b to 7.0.8.2 with mapdiffs enabled, and if anyone wants to use it, copy it to the main regions.dfn file and overwrite the New Haven region (57), while also removing the New Haven specific shop-regions (178 to 200)
DragonSlayer62
changed the title
Xoduz
reviewed
Jan 24, 2025
Xoduz
added
Changes Requested
|
udpated it now says (regions.dfn) |
DragonSlayer62
added
Ready for Review
and removed
Changes Requested
Xoduz
added
Changes Requested
DragonSlayer62
added
Ready for Review
and removed
Changes Requested
Xoduz
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added New Haven for trammel
Added New Haven Music
Added new player quest training areas
Fixed Britains music
marked old regions file as old because contains old haven