Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in snap GIS function to use node name as a tie breaker #370

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

kaklise
Copy link
Collaborator

@kaklise kaklise commented Aug 15, 2023

Summary

The snap GIS function was updated to use node name as a tie breaker when snap distances between multiple nodes are the same. This PR also includes documentation updates to improve readability of the user manual when built into a PDF.

Tests and documentation

  • Resolves test_snap_points_to_lines on py10
  • Minor documentation updates to improve readability

Acknowledgement

By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.

@kaklise kaklise requested a review from kbonney August 15, 2023 22:40
@coveralls
Copy link

Coverage Status

coverage: 84.417%. remained the same when pulling bba8bb2 on kaklise:docs into 94b0e87 on USEPA:main.

Copy link
Collaborator

@kbonney kbonney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation updates make sense.
GIS function update is clear as well, adds a second level of sorting to deal with ambiguity.

@kaklise kaklise merged commit 040bdb8 into USEPA:main Aug 17, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants