Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersect #386

Closed
wants to merge 6 commits into from
Closed

Intersect #386

wants to merge 6 commits into from

Conversation

kbonney
Copy link
Collaborator

@kbonney kbonney commented Oct 23, 2023

Summary

  • Pulled in updates to SNAP from CIMD project
    • Added new functions to return intersect stats and filter rows by intersection criterea
    • updated intersect to return the fraction of A that is intersected by B
    • updated intersect to improve efficiency
  • Changed how intersect handles A and B's indices so that multi-indices can be used
  • Changed how background is handled. Since the code now uses the integer index and background is appended to the end of B, sorting always will put BACKGROUND at the end of lists rather than the beginning.

Tests and documentation

Tests have been changed to update the changes in output for intersect. Also tests have been added to test multi-indices with intersect.

TODO

  • Decide if we want to support the fraction filtering and stats functions
    • Might be more appropriate to include the code in a tutorial for users to emulate.
  • Update docs

Acknowledgement

By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.

@kaklise kaklise closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants