Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging authentication info #21

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Fix logging authentication info #21

merged 2 commits into from
Aug 29, 2024

Conversation

stevapple
Copy link
Contributor

No description provided.

@iBug
Copy link
Member

iBug commented Aug 29, 2024

I think this is better fixed by wrapping the deferred call in a func() so that the evaluation of logger is also deferred.

Keep in mind that logger.Info(...) is equivalent to (*slog.Logger).Info(logger, ...).

@stevapple
Copy link
Contributor Author

I think this is better fixed by wrapping the deferred call in a func() so that the evaluation of logger is also deferred.

New things learned.

@iBug iBug merged commit 4946519 into USTC-vlab:master Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevapple @iBug