Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup-dav-sync.sh #6

Closed
wants to merge 2 commits into from

Conversation

Marc-Flender
Copy link
Contributor

syncevolution config Names used in the cron_handler must be cropped at 30 characters too

syncevolution config Names used in the cron_handler must be cropped at 30 characters too
@Marc-Flender
Copy link
Contributor Author

Hi,

I made a mistake, i forgot "$" before variables. Please reject my pull request (i dont know how to do it on GitHub

resolved problem of "$" before variables.
@SaltyCybernaut
Copy link
Collaborator

Hello @Marc-Flender, thank you for taking the time to identify bugs in my project and send the fixes upstream.

I will be rejecting this pull request because of the apparent unintended modification of lines 212, 213, and 266 which can be seen here. The variables on these lines were changed from an index into an array variable to the array variable itself, the uppercase styling for the global variables were changed to lower case, and the inclusion of curly braces '{' and '}' for verbosity were also stripped out.

Please resubmit a new pull request with a single commit modifying lines 187, 188, 195, and 196.

@Marc-Flender
Copy link
Contributor Author

Marc-Flender commented Jul 16, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants