refactor, fix: validate trpc & unsorted semesters bug #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel Preview URL 🚀 : https://planner-afu69hwyp-utdnebula.vercel.app |
cubetastic33
requested changes
Oct 20, 2023
|
Vercel Preview URL 🚀 : https://planner-m1czgo8ij-utdnebula.vercel.app |
cubetastic33
approved these changes
Oct 24, 2023
cubetastic33
added a commit
that referenced
this pull request
Nov 10, 2023
Revert "Merge pull request #716 from UTDNebula/refactor-validatets"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactored requisite validation logic under validator.ts. In the process, I encountered a major bug where the
semestersfrom the fetchedplanDatawas not sorted. The problem was that the requisite validation recursive function was comparing semester indices, which obviously would be broken with unsorted semesters. A fix is included in this PR.