Feature/smoother collapsing tiles #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with develop
chore: Sync with `develop`
Sync with develop (Migrating from Railway => Neon)
Sync with develop: validator merge
Sync with develop
Sync with main
Sync with develop
Sync with develop
smoother for the semester and transfer bank tiles
smoother for the semester and transfer bank tiles
Jake3231
force-pushed
the
feature/smoother-collapsing-tiles
branch
from
5311049 to
f557573
Compare
|
@ishaanthenerd Looks like the issues with the unexpected changes are that the IDE included a |
Jake3231
requested changes
Feb 6, 2024
There was a problem hiding this comment.
@ishaanthenerd Please run prettier and resolve other linting issues.
cubetastic33
requested changes
Feb 9, 2024
There was a problem hiding this comment.
@ishaanthenerd Please run prettier and eslint and re-request a review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves "Bug: Make Collapse/Expanding of Transfer Bank and Semester Tiles Smoother · Issue #433 · UTDNebula/planner"
What Changed
I added code to smoothly transition the collapsing and expanding of the semester tiles and the transfer bank. Although they now have fixed sizes when closed, they match the original sizes almost exactly.
Other Notes
I noticed that venv/bin/activate was acting strangely... don't merge changes related to that, only from SemesterTile and TransferBank.