Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changes to activate cron job that deletes old applications 7 days after role appointment is done and saved #795

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

Add changes to activate cron job that deletes old applications 7 days after role appointment is done and saved #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b1e4b38
Added changes to activate cron job that deletes old applications 7 da…
anandmatt Nov 30, 2023
3d3d52c
add newline at end of file
anandmatt Dec 4, 2023
f636f17
Fix build issues
robindymer Dec 6, 2023
4335bd1
Merge with dev
robindymer Dec 6, 2023
e54c8af
Merge branch 'development' into 786-delete-old-applications
robindymer Dec 6, 2023
1bb4242
resolve build errors
anandmatt Dec 12, 2023
afe7453
resolve flake build error
anandmatt Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/involvement/cron.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ def send_extension_emails():
def remove_old_applications():
old_applications = Application.objects.filter(
position__recruitment_end__lte=date.today() - timedelta(days=7)
).exclude(
status='appointed'
).filter(
status='turned_down'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to remove only turned_down applications is good, because currently, it expects that applications are appointed within a week of the application end date, which is not always the case. The status is set to turned_down only when they have been appointed.

)

for app in old_applications:
Expand Down
2 changes: 2 additions & 0 deletions src/involvement/forms/appointment_form.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from involvement.models import Application
from utils.forms import AdvancedModelMultipleChoiceField
from utils.unicore_client import UnicoreClient
from involvement import cron


class AppointmentForm(forms.Form):
Expand Down Expand Up @@ -99,3 +100,4 @@ def save(self):
if not created:
appl.status = 'appointed'
appl.save()
cron.remove_old_applications()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So a CRON-job is not supposed to be invoked manually, by definition. Unless there is some issue with django-kronos not installing the CRON-jobs correctly, I don't think there is any problem in terms of remove_old_applications not being called. The crontab on the server looks fine. So I think the change to invoke it without django-kronos should be removed.

Loading