-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constant latitude intersections using bounding box #1017
base: main
Are you sure you want to change the base?
Conversation
This implements Let me know if |
Feel free to merge any tests from #785 that are relevant to the candidate face computation also. |
Hi @philipc2 However, I don't think In fact, this is the only method we mathematically calculate the intersections correctly. All other "faster" methods didn't guarantee the intersection points and just gave some approximate results that "might work". So I feel like we should name this one similar to "mathematical intersections" and other methods as similar to "tentative methods". |
Thanks for the quick feedback! Good luck with your work this week! |
Hey @philipc2 thanks for putting this together, would be the first step to determine the faces to perform area correction when edge is around line of constant latitude or great circle arc? |
I don't believe this would require any area correction, as the bounding box implemented by @hongyuchen1030 already considers the spherical geometry. Though area calculation is definitely something that down the line is important, as a lot of calculations are area-weighted. |
For non-conservative zonal average, we don't need to consider area calculation. Area calculation is one of the last two steps of conservative zonal average. |
Closes #1018
Overview
Usage