Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinates conversion helpers overloads #347

Conversation

hongyuchen1030
Copy link
Contributor

@hongyuchen1030 hongyuchen1030 commented Jun 14, 2023

Overview

Enable node_xyz_to_lonlat_rad, node_lonlat_rad_to_xyz, normalize_in_place take np.array() as input and output

Modify the current node_xyz_to_lonlat_rad, node_lonlat_rad_to_xyz, normalize_in_place helper functions
such that: 1. it takes np.array() or list as input. 2. The output is in the np.array() format

Note:

Disable the numba @njit for all helpers.py since numba doesn't support the isinstance function

hongyuchen1030 and others added 30 commits May 17, 2023 21:13
…ection_through_verts' into multiprecision_unique_coords_detection_through_verts
…ection_through_verts' into multiprecision_unique_coords_detection_through_verts
@rajeeja
Copy link
Contributor

rajeeja commented Jun 23, 2023

Note:

Disable the numba @njit for all helpers.py since numba doesn't support the isinstance function

We can use type ducking type or Union type (python 3.10+) instead of isinstance they are supported by numba.

@hongyuchen1030
Copy link
Contributor Author

Note:

Disable the numba @njit for all helpers.py since numba doesn't support the isinstance function

We can use type ducking type or Union type (python 3.10+) instead of isinstance they are supported by numba.

sounds good. I will leave my implemented algorithm in the multi-precision branch. And feel free to adapt to any better delivery codes

@philipc2 philipc2 changed the base branch from main to multi_precision July 12, 2023 18:04
@philipc2
Copy link
Member

@hongyuchen1030

I have changed the base of this branch to point towards multi_precision instead of main

@hongyuchen1030
Copy link
Contributor Author

@hongyuchen1030

I have changed the base of this branch to point towards multi_precision instead of main

Thank you very much!

@aaronzedwick Can you help merge the redesign into this branch and merge it into the multi_precision branch please?

@aaronzedwick
Copy link
Member

@hongyuchen1030 I tried merging everything, but I am a bit confused about how to do it since this is your own fork. Should I check out your fork, and merge the main branch from the fork into this branch from the fork? And then push into your branch? Or is there some other way?

@aaronzedwick
Copy link
Member

I got everything merged into your branch, do you want me to push it directly?

@hongyuchen1030
Copy link
Contributor Author

I got everything merged into your branch, do you want me to push it directly?

Yes, you can directly commit to this branch. Thank you for your help.

@aaronzedwick aaronzedwick added the multiprecision Arbitrary-precision Arithmetic Implementations label Jul 14, 2023
@hongyuchen1030 hongyuchen1030 added new feature New feature or request and removed multiprecision Arbitrary-precision Arithmetic Implementations labels Jul 22, 2023
@hongyuchen1030 hongyuchen1030 changed the base branch from multi_precision to main July 22, 2023 16:32
@hongyuchen1030
Copy link
Contributor Author

@aaronzedwick This branch shouldn't be considered as multiprecision since it just overloads the normal coordinate conversion with the numpy.array() and it should be merged into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Status: 📚 Backlog
Development

Successfully merging this pull request may close these issues.

4 participants