-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinates conversion helpers overloads #347
Coordinates conversion helpers overloads #347
Conversation
…ection_through_verts' into multiprecision_unique_coords_detection_through_verts
…ection_through_verts' into multiprecision_unique_coords_detection_through_verts
…https://github.com/hongyuchen1030/uxarray into multiprecision_unique_coords_detection_through_verts
…https://github.com/hongyuchen1030/uxarray into multiprecision_unique_coords_detection_through_verts
We can use |
sounds good. I will leave my implemented algorithm in the multi-precision branch. And feel free to adapt to any better delivery codes |
…https://github.com/hongyuchen1030/uxarray into multiprecision_unique_coords_detection_through_verts
…que_coords_detection_through_verts Multiprecision unique coords detection through verts
I have changed the base of this branch to point towards |
Thank you very much! @aaronzedwick Can you help merge the redesign into this branch and merge it into the |
@hongyuchen1030 I tried merging everything, but I am a bit confused about how to do it since this is your own fork. Should I check out your fork, and merge the main branch from the fork into this branch from the fork? And then push into your branch? Or is there some other way? |
I got everything merged into your branch, do you want me to push it directly? |
Yes, you can directly commit to this branch. Thank you for your help. |
@aaronzedwick This branch shouldn't be considered as |
Overview
Enable
node_xyz_to_lonlat_rad
,node_lonlat_rad_to_xyz
,normalize_in_place
takenp.array()
as input and outputModify the current node_xyz_to_lonlat_rad, node_lonlat_rad_to_xyz, normalize_in_place helper functions
such that: 1. it takes np.array() or list as input. 2. The output is in the np.array() format
Note:
Disable the numba
@njit
for allhelpers.py
since numba doesn't support theisinstance
function