-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiprecision unique coords detection to __from_ds__
#372
Merged
hongyuchen1030
merged 7 commits into
multi_precision
from
origin/aaronzedwick/from_ds_multi_precision
Jul 21, 2023
Merged
Multiprecision unique coords detection to __from_ds__
#372
hongyuchen1030
merged 7 commits into
multi_precision
from
origin/aaronzedwick/from_ds_multi_precision
Jul 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
philipc2
changed the title
Multiprecision unique coords detection to
Multiprecision unique coords detection to Jul 11, 2023
__from_ds
`__from_ds__
`
aaronzedwick
changed the title
Multiprecision unique coords detection to
Multiprecision unique coords detection to Jul 11, 2023
__from_ds__
`__from_ds__
@hongyuchen1030 Could we get this merged if everything looks good? |
hongyuchen1030
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #318
Overview
Changes to __from_ds function to include multi-precision
Expected Usage
PR Checklist
General
Testing