Fix Upstream CI #410
Merged
Fix Upstream CI #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Successful run from this branch can be seen here |
This is the actual CI, and we can see the upstream CI results once this PR is merged and that workflow is run automatically as a cron job. However, with your changes, I'd expect it as well to pass. |
erogluorhan
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Approving to fix the upstream CI for now but we'd need to play with our upstream CI implementation again soon. See this for reference.
Here's the updated link, had it pointing towards the wrong job. |
rajeeja
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #409