[434] fix error when account not found

UffizziCloud · Jun 30, 2023 · 46b1123 · 46b1123
1 parent 00377dd
commit 46b1123
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/core/app/controllers/uffizzi_core/api/cli/v1/accounts_controller.rb b/core/app/controllers/uffizzi_core/api/cli/v1/accounts_controller.rb
@@ -24,8 +24,6 @@ def index
   # @response [object<account: <object<id: integer, name: string, projects: Array<object<id: integer, slug: string>>>> >] 200 OK
   # @response 401 Not authorized
   def show
-    raise ActiveRecord::NotFound if resource_account.blank?
-
     respond_with resource_account
   end
 
@@ -38,6 +36,10 @@ def policy_context
   end
 
   def resource_account
-    @resource_account ||= current_user.accounts.find_by(name: params[:name])
+    @resource_account ||= if params[:name]
+      current_user.accounts.find_by!(name: params[:name])
+    else
+      current_user.default_account
+    end
   end
 end
diff --git a/core/test/controllers/uffizzi_core/api/cli/v1/accounts_controller_test.rb b/core/test/controllers/uffizzi_core/api/cli/v1/accounts_controller_test.rb
@@ -15,10 +15,8 @@ class UffizziCore::Api::Cli::V1::AccountsControllerTest < ActionController::Test
   end
 
   test '#show' do
-    account = @user.personal_account
+    get :show, params: { name: 'wrong' }, format: :json
 
-    get :show, params: { name: account.name }, format: :json
-
-    assert_response(:success)
+    assert_response(:not_found)
   end
 end