Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete device pairings #2500

Merged
merged 1 commit into from
Feb 26, 2025
Merged

feat: delete device pairings #2500

merged 1 commit into from
Feb 26, 2025

Conversation

ert78gb
Copy link
Member

@ert78gb ert78gb commented Jan 14, 2025

@ert78gb
Copy link
Member Author

ert78gb commented Jan 14, 2025

@kareltucek Could you help me identify why the EraseBleSettings (0x1d) USB command is not working for me?

I use the UltimateHackingKeyboard/firmware@c9fa41a (current master) CI build: https://github.com/UltimateHackingKeyboard/firmware/actions/runs/12746615391

0x1b 0xad 0xbf 0x02 0x28 0xea is the BLE address of my Dongle.

You can see my Dongle is paired

❯ ./packages/usb/send-command.ts --log=usb 0x1b 0x1b 0xad 0xbf 0x02 0x28 0xea
[UhkHidDevice] USB[W]: 04 1b 1b ad bf 02 28 ea 
[UhkHidDevice] USB[R]: 04 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 

After that I run the erase ble address command

❯ ./packages/usb/send-command.ts --log=usb 0x1d
[UhkHidDevice] USB[W]: 04 1d 
[UhkHidDevice] USB[R]: 04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 

I query again the pairing status of the dongel

❯ ./packages/usb/send-command.ts --log=usb 0x1b 0x1b 0xad 0xbf 0x02 0x28 0xea
[UhkHidDevice] USB[W]: 04 1b 1b ad bf 02 28 ea 
[UhkHidDevice] USB[R]: 04 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 

Still paired. What am I doing wrong? thx

@kareltucek
Copy link
Contributor

This is my bad. I did literaly only erase the settings, but clearly the bonds still live on RAM. Will fix it tomorrow.

@ert78gb ert78gb force-pushed the feat-delete-device-pairings branch from f2f8446 to 95a5fb9 Compare February 22, 2025 15:42
@ert78gb
Copy link
Member Author

ert78gb commented Feb 22, 2025

@kareltucek Did you have time to check it? I retested with 12.3.5 firmware and I still have to power cycle my UHK to refresh bonds.

@kareltucek
Copy link
Contributor

Sorry, forgotten about it :-(

@ert78gb
Copy link
Member Author

ert78gb commented Feb 22, 2025

No worries. You will do it when you will have time or it will the priority

@ert78gb ert78gb force-pushed the feat-delete-device-pairings branch from 8adc07a to 0c32251 Compare February 26, 2025 19:30
@ert78gb ert78gb marked this pull request as ready for review February 26, 2025 19:33
@ert78gb ert78gb requested a review from mondalaci February 26, 2025 19:33
@mondalaci mondalaci merged commit 17b7d7e into master Feb 26, 2025
4 checks passed
@mondalaci mondalaci deleted the feat-delete-device-pairings branch February 26, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete device pairings
3 participants