Sharp resolution #30
Open
Sharp resolution #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UmangSharma5
force-pushed
the
sharp-resolution
branch
from
5a61b32 to
ab38478
Compare
shaantanu314
reviewed
Jan 5, 2024
| console.log("percen-->",now); | ||
| return <ProgressBar now={now} label={`${now}%`} />; | ||
| let val = Math.floor(props.percentage); | ||
| console.log("percen-->",val); |
Comment on lines
9
to
12
| // BootstrapProgressBar.propTypes = { | ||
| // percentage: PropTypes.number.isRequired, | ||
| // }; | ||
|
|
| let now = Math.floor(props.percentage); | ||
| console.log("percen-->",now); | ||
| return <ProgressBar now={now} label={`${now}%`} />; | ||
| let val = Math.floor(props.percentage); |
client/src/components/statusInfo.js
Outdated
|
|
||
| const StatusInfo = (props) => { | ||
| const [showThumbnails, setShowThumbnails] = useState(false); | ||
|
|
||
| return ( | ||
| <div> | ||
| {console.log("statusinfo files props --->",props.uploadPercentage)} | ||
| {console.log("statusinfo files props --->", props.uploadPercentage)} |
server/routes/objects.js
Outdated
| try { | ||
| let user = await get_user_bucket(req.user.user_email); // get this from database (sql) | ||
| let bucketName = "datadrive-dev"; | ||
| if (user == undefined) { |
There was a problem hiding this comment.
!user will work here
There was a problem hiding this comment.
remove comments in this file
Comment on lines
+193
to
+195
| // let filePath; | ||
| // let cnt = 0; | ||
|
|
| childProcess.stdout.on('data', data => { | ||
| // Handle standard output data | ||
| // console.error(`stdout: ${data}`); | ||
| const matches = String(data).match(/:\s*(\d+)/); |
There was a problem hiding this comment.
write a comment here, what we are trying to do here.
Comment on lines
+342
to
+343
| const targetWidth = 500; | ||
| const targetHeight = 400; |
There was a problem hiding this comment.
This should be in constants.js
and 500x400 is still large right?
| ); | ||
| // console.error("Directory delete successful", tmpDirPath); | ||
| }); | ||
| }, 1000 * 1000); |
There was a problem hiding this comment.
move this also to constants
TMP_DELETE_TIME = 5601000 // 5 mins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharp resolution and changes in semaphore (made it async)