Global signin #35
Global signin #35
Conversation
…ReactViewer into revert-socket.io
client/src/App.js
Outdated
| const GET_URL_DEV = | ||
| 'https://datafoundation.iiit.ac.in/api/detokn?token=' + tokenId; | ||
| // const GET_URL_DEV = 'http://10.4.25.20:3001/api/detokn?token=' + tokenId; |
There was a problem hiding this comment.
move this to constants
There was a problem hiding this comment.
Capital case is only used when it is a global constant
client/src/App.js
Outdated
| const GET_URL_DEV = | ||
| 'https://datafoundation.iiit.ac.in/api/detokn?token=' + tokenId; | ||
| // const GET_URL_DEV = 'http://10.4.25.20:3001/api/detokn?token=' + tokenId; |
There was a problem hiding this comment.
pls remove comments in PR
client/src/App.js
Outdated
| if (isLoggedIn) { | ||
| return <Navigate replace to="/" />; | ||
| } else { | ||
| // <Login checkUser={checkUser} /> |
There was a problem hiding this comment.
- login component is not needed. Delete the file
| // <Login checkUser={checkUser} /> | ||
| window.location.href = | ||
| 'https://datafoundation.iiit.ac.in/sign-in?redirect=/hv'; | ||
| return <p>Redirecting ...</p>; |
There was a problem hiding this comment.
why is this required?
There was a problem hiding this comment.
This redirects to login url
There was a problem hiding this comment.
config files are not supposed to be pushed. Had pointed out this thing in your previous PR also, if this gets merged, we would have to change the file in server manually.
There was a problem hiding this comment.
config is just for development purpose
|
@RhythmAgg Add video in PR
|
.gitignore
Outdated
| node_modules | ||
| client/src/components/Config |
global-signin-demo.mp4Attached is the demo video for the global signin |
Global Signin