-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logic #1226
Logic #1226
Conversation
This PR is currently blocked on #1168. |
Turns out it's not directly blocked, there's just an overlap. |
Sorry that this PR was left open for so long. I'll review it tomorrow or in the coming days. Could you get it up to date, if there is anything you wanted to change? |
I don't believe I want to add anything more to this PR, so review away. Thanks for taking on this huge PR! |
I just realized I want to factor "Markovian types" into a separate file. I will do so quickly. The rest can be reviewed in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very cool pull request!
src/foundation/axiom-of-choice-implies-law-of-excluded-middle.lagda.md
Outdated
Show resolved
Hide resolved
src/foundation/axiom-of-choice-implies-law-of-excluded-middle.lagda.md
Outdated
Show resolved
Hide resolved
By the way @EgbertRijke, do you have an opinion on whether Markov's principle should be placed in |
Would you want decidable types to be moved to the |
I've addressed all of your comments now.
This question is relevant for where I should place the new module |
It would probably be fair to place them all in |
Hm.. that's a good question. I'm not sure where to draw the line between type theory and logic. The most obvious way to do it is that generic stuff about propositions should go in logic. On the other hand, the Curry-Howard interpretation of logic into type theory also feels like logic, but perhaps I'd feel more comfortable about having the logic namespace mostly for proposition-level mathematics. |
This pull request is a great advance for the library! Well done Fredrik! |
Some logic formalizations extracted from #1206.
Summary
logic
namespaceInitial work for #1069