Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the change:
Currently, when I set
alphanumeric_filename
and upload file with accents like Test - Žluťoučký kůň.pdf I got file namedTest-__lu__ou________k____.pdf
. In my PR I propose to useStr::slug()
instead ofpreg_replace()
.I also extended alphanumeric functionality with
convert_to_alphanumeric
config option. If this is set totrue
, then when renaming or creating folder user inputs some non-alphanum characters, everything is converted to alphanum withStr::slug()
instead of poping error out.