Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slug instead of preg_replace #941

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arxeiss
Copy link

@arxeiss arxeiss commented May 13, 2020

Summary of the change:

Currently, when I set alphanumeric_filename and upload file with accents like Test - Žluťoučký kůň.pdf I got file named Test-__lu__ou________k____.pdf. In my PR I propose to use Str::slug() instead of preg_replace().

I also extended alphanumeric functionality with convert_to_alphanumeric config option. If this is set to true, then when renaming or creating folder user inputs some non-alphanum characters, everything is converted to alphanum with Str::slug() instead of poping error out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant