Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CCL/EL/LFC docstring to reflect that pressure should be monotonically decreasing #3114

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Update CCL/EL/LFC docstring to reflect that pressure should be monotonically decreasing #3114

merged 3 commits into from
Jul 20, 2023

Conversation

Z-Richard
Copy link
Contributor

Description Of Changes

Update the docstring of ccl, el, and lfc to reflect that pressure should be monotonically decreasing.

Checklist

@Z-Richard Z-Richard requested a review from a team as a code owner July 13, 2023 02:18
@Z-Richard Z-Richard requested review from dopplershift and removed request for a team July 13, 2023 02:18
@dopplershift dopplershift added Area: Docs Affects documentation Type: Enhancement Enhancement to existing functionality Area: Calc Pertains to calculations labels Jul 17, 2023
@dopplershift dopplershift added this to the September 2023 milestone Jul 17, 2023
dopplershift
dopplershift reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending in the fix. Only a minor nit against the original code.

src/metpy/calc/thermo.py Outdated Show resolved Hide resolved
@Z-Richard @dopplershift
Avoid msg in the code
5a9e6b2 
Co-authored-by: Ryan May <[email protected]>
dopplershift
dopplershift approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adjusting.

@dopplershift dopplershift enabled auto-merge (squash) July 19, 2023 23:23
@dopplershift dopplershift merged commit d9bfba6 into Unidata:main Jul 20, 2023
25 checks passed
@Z-Richard Z-Richard deleted the ccl-docfix branch July 21, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
Area: Calc Pertains to calculations Area: Docs Affects documentation Type: Enhancement Enhancement to existing functionality
Projects
None yet
Milestone
December 2023
Development

Successfully merging this pull request may close these issues.

Better docstring specification for CCL, EL, and LFC
2 participants
@Z-Richard @dopplershift