Completely remove use of setup.py #3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates running setup.py by hand.
Everything works through pyproject.toml, we don't need a setup.py and we can safely eliminate Python 2 handling fallback--we dropped Python 2 5 years ago.
Some of this was already outdated by the move to pyproject.toml, but now there's no setup.py.
dopplershift
added
Area: Infrastructure
dcamron
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Partially motivated by an error from #3624, but it's time to elminate
setup.pycompletely:buildtool rather than runningsetup.pydirectly to build the sdist and wheels 😬pyproject.tomlhad all the metadata that was previously insetup.pysetup.pyand its fallback handling for Python 2 (we dropped Python 2 5 years ago in Drop support for Python 2.7! #1163)Checklist