Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly suppress variable length type compression #2730

Merged
merged 1 commit into from
Aug 10, 2023

Commits on Aug 3, 2023

  1. Explicitly suppress variable length type compression

    re: PR Unidata#2716).
    re: Issue Unidata#2189
    
    The basic change is to make use of the fact that HDF5 automatically suppresses optional filters when an attempt is made to apply them to variable-length typed arrays.
    This means that e.g. ncdump or nccopy will properly see meaningful data.
    Note that if a filter is defined as HDF5 mandatory, then the corresponding variable will be suppressed and will be invisible to ncdump and nccopy.
    This functionality is also propagated to NCZarr.
    
    This PR makes some minor changes to PR Unidata#2716 as follows:
    * Move the test for filter X variable-length from dfilter.c down into the dispatch table functions.
    * Make all filters for HDF5 optional rather than mandatory so that the built-in HDF5 test for filter X variable-length will be invoked.
    
    The test case for this was expanded to verify that the filters are defined, but suppressed.
    DennisHeimbigner committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    db772ce View commit details
    Browse the repository at this point in the history