Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup various obsolete build issues #2926

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

DennisHeimbigner
Copy link
Collaborator

Description

Remove various obsolete build options. Also do some code movement.

Specific Changes

  • The remotetest server is sometimes unstable, so provide a mechanism to force disabling calls to remotetest.unidata.ucar.edu. This is enabled by adding a repository variable named REMOTETESTDOWN with the value "yes".
  • Fix CMakeLists.txt to use the uname command as an alternate to using the hostname command (which does not work under cygwin).
  • Remove the JNA stuff as obsolete
  • Remove the ENABLE_CLIENTSIDE_FILTERS options since it has been disabled for a while.
  • Fix bad option flag in some github action .yml files: change --disable-xml2 to --disable-libxml2
  • Collect globalstate definitions into nc4internal.h
  • Remove ENABLE_NCZARR_FILTERS_TESTING option as obsolete and replace with ENABLE_NCZARR_FILTERS
  • Move some dispatcher independent functions from libsrc4/nc4internal.c to libdispatch/ddispatch.c
  • As a long term goal, and because it is now the case that --enable-nczarr => USE_NETCDF4, make the external options --enable-netcdf-4 and --enable-netcdf4 obsolete in favor of --enable-hdf5 We will do the following for one more release cycle. 1. Make --enable-netcdf-4 be an alias for --enable-netcdf4. 2. Make --enable-netcdf4 an alias for --enable-hdf5. 3. Internally, convert most uses of USE_NETCDF_4 ad USE_NETCDF4 to USE_HDF5 After the next release, --enable-netcdf-4 and --enable-netcdf4 will be removed.

# Description
Remove various obsolete build options. Also do some code movement.

## Specific Changes

* The remotetest server is sometimes unstable, so provide a mechanism
  to force disabling calls to remotetest.unidata.ucar.edu.
  This is enabled by adding a repository variable named
  REMOTETESTDOWN with the value "yes".
* Fix CMakeLists.txt to use the uname command as an alternate
  to using the hostname command (which does not work under cygwin).
* Remove the JNA stuff as obsolete
* Remove the ENABLE_CLIENTSIDE_FILTERS options since it has been
  disabled for a while.
* Fix bad option flag in some github action .yml files: change --disable-xml2 to --disable-libxml2
* Collect globalstate definitions into nc4internal.h
* Remove ENABLE_NCZARR_FILTERS_TESTING option as obsolete and replace
  with ENABLE_NCZARR_FILTERS
* Move some dispatcher independent functions from libsrc4/nc4internal.c to libdispatch/ddispatch.c
* As a long term goal, and because it is now the case that --enable-nczarr
    => USE_NETCDF4, make the external options --enable-netcdf-4 and
    --enable-netcdf4 obsolete in favor of --enable-hdf5
    We will do the following for one more release cycle.
        1. Make --enable-netcdf-4 be an alias for --enable-netcdf4.
        2. Make --enable-netcdf4 an alias for --enable-hdf5.
        3. Internally, convert most uses of USE_NETCDF_4 ad USE_NETCDF4 to USE_HDF5
    After the next release, --enable-netcdf-4 and --enable-netcdf4 will
    be removed.
@DennisHeimbigner DennisHeimbigner changed the title Cleanup various Zarr-related build issues Cleanup various obsolete build issues May 16, 2024
include/nc.h Show resolved Hide resolved
@WardF WardF self-assigned this May 17, 2024
@WardF WardF added this to the 4.9.3 milestone May 17, 2024
@WardF WardF merged commit 517d0b4 into Unidata:main May 20, 2024
106 checks passed
@DennisHeimbigner DennisHeimbigner deleted the cleanup.dmh branch June 20, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants