Improve performance of enhancement providers by only loading once

Unidata · Jul 23, 2024 · c0da0fe · c0da0fe
1 parent f930ae4
commit c0da0fe
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/cdm/core/src/main/java/ucar/nc2/dataset/VariableDS.java b/cdm/core/src/main/java/ucar/nc2/dataset/VariableDS.java
@@ -34,7 +34,7 @@
  */
 public class VariableDS extends Variable implements VariableEnhanced, EnhanceScaleMissingUnsigned {
 
-
+  static final ServiceLoader<EnhancementProvider> ENHANCEMENT_PROVIDERS = ServiceLoader.load(EnhancementProvider.class);
 
   /**
    * Constructor when there's no underlying variable.
@@ -933,7 +933,7 @@ private void createEnhancements() {
       this.dataType = scaleOffset != null ? scaleOffset.getScaledOffsetType() : this.dataType;
     }
     for (Enhance enhance : this.enhanceMode) {
-      for (EnhancementProvider service : ServiceLoader.load(EnhancementProvider.class)) {
+      for (EnhancementProvider service : ENHANCEMENT_PROVIDERS) {
         if (service.appliesTo(enhance, this.attributes(), dataType)) {
           loadedEnhancements.add(service.create(this));
         }