Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert axis name changes and add work done to use coordVars to set co… #1360

Merged
merged 3 commits into from
Jul 10, 2024
Merged

revert axis name changes and add work done to use coordVars to set co… #1360

merged 3 commits into from
Jul 10, 2024

Conversation

haileyajohnson
Copy link
Contributor

@haileyajohnson haileyajohnson commented Jul 9, 2024 •
edited
Loading

  • reverts time and alt axis names changes from Cf anyPoint writer rework to use multiple altNames and timeNames #1275 to fix DSGSubsetWriter for NCSS
  • adds constructors that contain a list of coordinate variables to point feature implementations and point writers
  • future work to make the CF Point writers more accurately represent the dataset they're writing should use coordinate axis info taken from the list of coordinate variables

@haileyajohnson haileyajohnson marked this pull request as ready for review July 9, 2024 18:40
@haileyajohnson haileyajohnson requested a review from tdrwenski July 9, 2024 18:40
@haileyajohnson haileyajohnson force-pushed the revert-writer branch 2 times, most recently from 4e30655 to 2ff52bb Compare July 9, 2024 23:57
@haileyajohnson haileyajohnson merged commit a9a1f11 into Unidata:maint-5.x Jul 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdrwenski tdrwenski tdrwenski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haileyajohnson @tdrwenski