Only update affected media list when updating destination in HTMX frontend

[stveit]

Fixes #1136

Makes it so only the related list for the destination you try to delete is updated with HTMX.

[github-actions]

Test results

   10 files  1 060 suites   38m 23s ⏱️
  536 tests   535 ✅  1 💤 0 ❌
5 360 runs  5 350 ✅ 10 💤 0 ❌

Results for commit 34dd036.

♻️ This comment has been updated with latest results.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 79.62%. Comparing base (8b98bad) to head (34dd036).

Files with missing lines	Patch %	Lines
src/argus/htmx/destination/views.py	7.69%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1121      +/-   ##
==========================================
- Coverage   79.67%   79.62%   -0.05%     
==========================================
  Files         141      141              
  Lines        5288     5292       +4     
==========================================
+ Hits         4213     4214       +1     
- Misses       1075     1078       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[johannaengland]

Should also have a news fragment (could also be one for #1120 and this PR together), otherwise good

[podliashanyk]

Nice! See a RFC below

[podliashanyk]

Having same id on several HTML tags is a bad practice. We could either make an id of each form unique with something like update-delete-form-{{ media.name }}-{{ forloop.counter }}, or put a class f.e. update-delete-form on each form and target it as closest .update-delete-form. The latter is easiest

[hmpf]

If prefix is set when instantiating the form, it is available via {{form.prefix}}. This can then be used to give the form itself an id. However, this also adds the prefix to every field-id (must be unique per page) and field-name, so that every form dealing with the same data must have the same prefix set. See #1118 for prefix-wrangling.

[stveit]

This was changed to not rely on ID anymore, now it uses "closest detail", finding the closest collapse element

[hmpf]

There will never be many destinations, a refresh of the entire page is also fine and will greatly simplify matters I suspect.

[stveit]

Changed PR to focus on updating the entire list and not just the row

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[podliashanyk]

Works nicely!

The only UX issue I see is that the error message on destination delete is shown not by the destination in question, but at the top of the media list which is confusing. But this issue was likely introduced in #1120 and not in this PR.

[stveit]

Works nicely!

The only UX issue I see is that the error message on destination delete is shown not by the destination in question, but at the top of the media list which is confusing. But this issue was likely introduced in #1120 and not in this PR.

#1143