Skip to content

Commit

Permalink
feat: remove duplicate validation from v2 (#244)
Browse files Browse the repository at this point in the history
EndTimeBeforeStartTime is already validated inside of DutchDecayLib
  • Loading branch information
marktoda authored Apr 16, 2024
1 parent ad671bf commit 166db86
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/reactors/V2DutchOrderReactor.sol
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@ contract V2DutchOrderReactor is BaseReactor {
revert DeadlineBeforeEndTime();
}

if (order.cosignerData.decayEndTime <= order.cosignerData.decayStartTime) {
revert DutchDecayLib.EndTimeBeforeStartTime();
}

(bytes32 r, bytes32 s) = abi.decode(order.cosignature, (bytes32, bytes32));
uint8 v = uint8(order.cosignature[64]);
// cosigner signs over (orderHash || cosignerData)
Expand Down

0 comments on commit 166db86

Please sign in to comment.