feat: handle invalid signature #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marktoda
force-pushed
the
check-invalid-signature
branch
2 times, most recently
from
e61d747 to
e1f5def
Compare
This commit handles the case where cosignature is invalid, reverting. It also removes the special casing for address(0) cosigner specified by the user, as that would enable any filler to arbitrarily set the auction timings Issue: Cantina #23
marktoda
force-pushed
the
check-invalid-signature
branch
from
e1f5def to
d56c833
Compare
zhongeric
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit handles the case where cosignature is invalid, reverting.