feat: standardize rounding in favour of swapper #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marktoda
force-pushed
the
standardize-rounding
branch
from
e46572d to
c71c423
Compare
zhongeric
previously approved these changes
Apr 15, 2024
test/lib/ExclusivityLib.t.sol
Outdated
| import {MockExclusivityLib} from "../util/mock/MockExclusivityLib.sol"; | ||
| import {ExclusivityLib} from "../../src/lib/ExclusivityLib.sol"; | ||
| import {OrderInfo, ResolvedOrder, OutputToken} from "../../src/base/ReactorStructs.sol"; | ||
| import {OrderInfoBuilder} from "../util/OrderInfoBuilder.sol"; | ||
|
|
||
| contract ExclusivityLibTest is Test { | ||
| using FixedPointMathLib for uint256; | ||
| using FixedPointMathLib for uint128; |
There was a problem hiding this comment.
imported but no added test?
zhongeric
previously approved these changes
Apr 18, 2024
This commit changes decay to standardize rounding in favour of swapper - rounding output amounts up and input amounts down
marktoda
force-pushed
the
standardize-rounding
branch
from
76ebc66 to
0ba43e4
Compare
zhongeric
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes decay to standardize rounding in favour of swapper