Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy the quoter as well as the quoter v2 #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wbl
Copy link

@wbl wbl commented Feb 16, 2022

The Uniswap frontend relies on the original quoter interface and will
not work on a testnet with only quoter v2.

Fixes Issue #6

The Uniswap frontend relies on the original quoter interface and will
not work on a testnet with only quoter v2.

Fixes Issue Uniswap#6
@wbl
Copy link
Author

wbl commented Feb 17, 2022

@NoahZinsmeister I can't figure out how to add you as a reviewer. Could you please take a look at this enhancement? The big diff is to the yarn lockfile, which I don't really understand why it happened as I'm pretty new, but I can probably figure out how to fix it.

@wbl
Copy link
Author

wbl commented Feb 17, 2022

@moodysalem @asood123 do either of you have time to take a look?

@moodysalem
Copy link
Contributor

would rather a pr that makes the interface use v2 quoter if possible

@wbl
Copy link
Author

wbl commented Feb 17, 2022

I agree that would be preferable, but I'm not entirely sure what the status of deployment and the address are on all the chains, which is why I didn't end up trying that approach.

It does seem like the only difference is some additional return data, so it wouldn't be a huge PR to make, even for someone with as minimal frontend skills as me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants