Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(smart-wallet): Initial commit #319

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat(smart-wallet): Initial commit #319

wants to merge 17 commits into from

Conversation

zhongeric
Copy link
Contributor

@zhongeric zhongeric commented Feb 28, 2025

PR Scope

Description

Add base implementation for smart wallet SDK.

Notable changes:

  • Added viem as a dep
  • Bumped typescript to work with viem
  • Added SmartWallet class, and encoder + callPlanner.

SmartWallet:

  • Main entrypoint for consumers
  • Supports encode* and create* functions
  • Encode returns MethodParameters, create returns Call

Helper classes:

CallPlanner:

  • Take a series of Calls and abi encode them

How Has This Been Tested?

Unit tests

Are there any breaking changes?

[e.g. Type definitions, API definitions]

If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.

(Optional) Feedback Focus

[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]

(Optional) Follow Ups

[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]

@zhongeric zhongeric requested review from a team as code owners February 28, 2025 19:12
@zhongeric zhongeric marked this pull request as draft February 28, 2025 19:12
Copy link

socket-security bot commented Mar 3, 2025

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected]25.5.1 None +7 54.5 MB tsjest
npm/[email protected] None 0 22.9 MB typescript-bot
npm/[email protected] network +10 25.5 MB jmoxey

View full report↗︎

Have feedback? Participate in our User Experience Survey 📊

@zhongeric zhongeric marked this pull request as ready for review March 3, 2025 23:49
Copy link
Member

@snreynolds snreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit lgtm tho! just gotta get CI passing 🚢

@graphite-app graphite-app bot requested a review from a team March 4, 2025 19:34
Copy link

graphite-app bot commented Mar 4, 2025

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (03/04/25)

2 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants