Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zora addresses #439

Merged
merged 4 commits into from
Jan 22, 2025
Merged

zora addresses #439

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84fa76a
zora addresses
dianakocsis Jan 17, 2025
258836e
fix address
dianakocsis Jan 17, 2025
cf50067
correct nft position manager
dianakocsis Jan 22, 2025
d29138a
fix name
dianakocsis Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions script/deployParameters/DeployZora.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.15;

import {DeployUniversalRouter} from '../DeployUniversalRouter.s.sol';
import {RouterParameters} from 'contracts/types/RouterParameters.sol';

contract DeployWorldchain is DeployUniversalRouter {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
contract DeployWorldchain is DeployUniversalRouter {
contract DeployZora is DeployUniversalRouter {

function setUp() public override {
params = RouterParameters({
permit2: 0x000000000022D473030F116dDEE9F6B43aC78BA3,
weth9: 0x4200000000000000000000000000000000000006,
v2Factory: 0x0F797dC7efaEA995bB916f268D919d0a1950eE3C,
v3Factory: 0x7145F8aeef1f6510E92164038E1B6F8cB2c42Cbb,
pairInitCodeHash: 0x96e8ac4277198ff8b6f785478aa9a39f403cb768dd02cbee326c3e7da348845f,
poolInitCodeHash: 0xe34f199b19b2b4f47f68442619d555527d244f78a3297ea89325f843f87b8b54,
v4PoolManager: address(0),
v3NFTPositionManager: 0x7145F8aeef1f6510E92164038E1B6F8cB2c42Cbb,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the v3 factory, it should be 0xbC91e8DfA3fF18De43853372A3d7dfe585137D78

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya should be 0xbC91e8DfA3fF18De43853372A3d7dfe585137D78

v4PositionManager: address(0)
});
}
}
Loading