Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor subgraph to support multiple chains #233

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

mzywang
Copy link
Collaborator

@mzywang mzywang commented May 31, 2024

Refactors main to support deploying all networks of the v3 subgraph

Copy link
Collaborator Author

mzywang commented May 31, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mzywang and the rest of your teammates on Graphite Graphite

@mzywang mzywang force-pushed the 05-31-refactor_subgraph_to_support_multiple_chains branch 11 times, most recently from 42e6436 to 75fb116 Compare June 4, 2024 17:54
@mzywang mzywang force-pushed the 05-31-refactor_subgraph_to_support_multiple_chains branch from 75fb116 to c1f81e9 Compare June 4, 2024 17:55
src/backfill/index.ts Outdated Show resolved Hide resolved
@mzywang mzywang marked this pull request as ready for review June 4, 2024 17:56
@mzywang mzywang force-pushed the 05-31-refactor_subgraph_to_support_multiple_chains branch from 1ecc521 to 655d764 Compare June 4, 2024 18:48
Copy link

@andysmith415 andysmith415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge! Will let @ianlapham dig in more.

src/backfill/index.ts Outdated Show resolved Hide resolved
src/utils/chains.ts Outdated Show resolved Hide resolved
Copy link
Member

@ianlapham ianlapham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just some nits

only question is, would changing the schema be a big lift for our apps? wondering if its finally time to change derivedETH to derivedNative

if too much work seems fine

@mzywang
Copy link
Collaborator Author

mzywang commented Jun 21, 2024

@ianlapham i think it would require a resync so it wouldn't be a lot of active work but a lot of passive waiting and coming back to the subgraphs when they finish syncing. i don't think it's worth it to do now but if we ever need to resync the subgraphs for whatever reason that would be a good opportunity to do so

@mzywang mzywang force-pushed the 05-31-refactor_subgraph_to_support_multiple_chains branch 2 times, most recently from b658543 to 04c87b1 Compare June 21, 2024 15:57
@mzywang mzywang force-pushed the 05-31-refactor_subgraph_to_support_multiple_chains branch from 04c87b1 to 3ab5b27 Compare June 21, 2024 16:42
@mzywang mzywang merged commit 99a325a into main Jun 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants