Add weth wrapping hook #436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note one constraint of this approach is that the input currency must already exist in poolmanager before the swap call. This could either be from existing standing liquidity or else the user must transfer input assets first |
hensha256
reviewed
Feb 3, 2025
marktoda
force-pushed
the
add-weth-wrapping-hook
branch
from
73bb4a1 to
a13739b
Compare
hensha256
reviewed
Feb 7, 2025
hensha256
reviewed
Feb 7, 2025
| ) | ||
| ) | ||
| ); | ||
| deployCodeTo("./foundry-out/WETHHook.sol/WETHHook.default.json", abi.encode(manager, weth), address(hook)); |
There was a problem hiding this comment.
ooh whats the difference between this and etch? 👀 ive always used etch, never seen this function before
There was a problem hiding this comment.
etch you have to have the bytecode inline. best way to get that was to deploy a dummy version and then etch the bytecode over to the right address. but that the dummy version reverts on hook validation - so this lets me skip the dummy deployments tep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
token wrapper adapter
Overview
This PR introduces a WETH (Wrapped Ether) hook for Uniswap v4, enabling native ETH to WETH conversions directly through v4 pools. The implementation provides a convenient way to wrap and unwrap ETH within a v4 lock / route.