pkg(tracphone): improve descriptions and add package #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
|
AnonymousWP
added
package::documentation
AnonymousWP
requested changes
Sep 12, 2024
| @@ -37724,4 +37724,22 @@ | |||
| "labels": [], | |||
| "removal": "Expert" | |||
| } | |||
| } | |||
| "com.samsung.unifiedtp":{ | |||
There was a problem hiding this comment.
Suggested change
| "com.samsung.unifiedtp":{ | |
| "com.samsung.unifiedtp": { |
Without a space it breaks the list.
| "removal": "Advanced" | ||
| } | ||
| } | ||
| "com.sec.android.app.tfstatus":{ |
There was a problem hiding this comment.
Suggested change
| "com.sec.android.app.tfstatus":{ | |
| "com.sec.android.app.tfstatus": { |
Same as above.
| @@ -4375,7 +4375,7 @@ | |||
| }, | |||
| "com.samsung.android.net.wifi.wifiguider": { | |||
| "list": "Oem", | |||
| "description": "Wi-Fi Tips\nShows a question-mark button next to Wi-Fi networks that failed to connect for any reason, providing info to fix the specific issue. It also has a dedicated Settings activity that lists all possible help-tips, accessible via the \"More tips\" button when reading a tip.\nUpon reinstalling a notification pops up saying \"Analyzing Wi-Fi\" for a few seconds, no idea what it's doing", | |||
| "description": "Wi-Fi Tips\nShows a question-mark button next to Wi-Fi networks that failed to connect for any reason, providing info to fix the specific issue. It also has a dedicated Settings activity that lists all possible help-tips, accessible via the \"More tips\" button when reading a tip.\nUpon reinstalling a notification pops up saying \"Analyzing Wi-Fi\" for a few seconds, no idea what it's doing WARNING: Removing make impossible to connect to wifi network without a detected internet connection!", | |||
There was a problem hiding this comment.
Suggested change
| "description": "Wi-Fi Tips\nShows a question-mark button next to Wi-Fi networks that failed to connect for any reason, providing info to fix the specific issue. It also has a dedicated Settings activity that lists all possible help-tips, accessible via the \"More tips\" button when reading a tip.\nUpon reinstalling a notification pops up saying \"Analyzing Wi-Fi\" for a few seconds, no idea what it's doing WARNING: Removing make impossible to connect to wifi network without a detected internet connection!", | |
| "description": "Wi-Fi Tips\nShows a question-mark button next to Wi-Fi networks that failed to connect for any reason, providing info to fix the specific issue. It also has a dedicated Settings activity that lists all possible help-tips, accessible via the \"More tips\" button when reading a tip.\nUpon reinstalling a notification pops up saying \"Analyzing Wi-Fi\" for a few seconds, no idea what it's doing.\nWARNING: removing makes it impossible to connect to a wifi network without a detected internet connection!", |
| @@ -6236,7 +6236,7 @@ | |||
| }, | |||
| "com.samsung.android.lool": { | |||
| "list": "Oem", | |||
| "description": "Samsung Device Care\n(https://play.google.com/store/apps/details?id=com.samsung.android.lool)\nThis package phone home (China, Qihoo 360)\nThe clean feature (in storage setting) is provided by Qihoo 360 which is a shady company (https://en.wikipedia.org/wiki/Qihoo_360)\nhttps://www.reddit.com/r/Android/comments/ektg8u/chinese_spyware_preinstalled_on_all_samsung/\nhttps://www.virustotal.com/gui/file/048ead2be8d18bbe2b05651380069b3740dd05703e9bd66630da986026518398/details\n\nWARNING:Disabling/Removing this package may remove the option to manage Power Saving, Fast Charging & Battery Protection on some devices\nNOTE : If you don't want to delete this package, at least use a firewall (Netguard/AfWall+) to block internet access\n", | |||
| "description": "Samsung Device Care\n(https://play.google.com/store/apps/details?id=com.samsung.android.lool)\n While this package was suspected previously to send lots of data to Chinese servers it has since been debunked - only connects to Chinese server to retrieve database , but still sends some very basic data about the phone like model number, storage capacity, and a randomly generated identifier https://www.reddit.com/r/Android/comments/el99r0/samsung_members_koreas_official_reply_has_arrived/ WARNING:Disabling/Removing this package may remove the option to manage Power Saving, Fast Charging & Battery Protection on some devices", | |||
There was a problem hiding this comment.
Suggested change
| "description": "Samsung Device Care\n(https://play.google.com/store/apps/details?id=com.samsung.android.lool)\n While this package was suspected previously to send lots of data to Chinese servers it has since been debunked - only connects to Chinese server to retrieve database , but still sends some very basic data about the phone like model number, storage capacity, and a randomly generated identifier https://www.reddit.com/r/Android/comments/el99r0/samsung_members_koreas_official_reply_has_arrived/ WARNING:Disabling/Removing this package may remove the option to manage Power Saving, Fast Charging & Battery Protection on some devices", | |
| "description": "Samsung Device Care\n(https://play.google.com/store/apps/details?id=com.samsung.android.lool)\nWhile this package was suspected previously to send lots of data to Chinese servers it has since been debunked - only connects to Chinese server to retrieve database, but still sends some very basic data about the phone like model number, storage capacity, and a randomly generated identifier:\nhttps://www.reddit.com/r/Android/comments/el99r0/samsung_members_koreas_official_reply_has_arrived/\nWARNING: disabling/removing this package may remove the option to manage Power Saving, Fast Charging & Battery Protection on some devices", |
| @@ -6590,7 +6590,7 @@ | |||
| }, | |||
| "com.sec.internal.vsim.VSimServiceApp": { | |||
| "list": "Oem", | |||
| "description": "Non Sim Device Solution (NSDS) needed for VoLTE and VoWifi (Wifi Calling) if you have a virtual SIM.\nSee com.sec.vsimservice\nUses IMS service\n", | |||
| "description": "Non Sim Device Solution (NSDS) needed for VoLTE and VoWifi (Wifi Calling) if you have a virtual SIM. Enabled in devices without esims for some reason. Not sure if there are non-esim virtual sims? \nSee com.sec.vsimservice\nUses IMS service\n", | |||
There was a problem hiding this comment.
Suggested change
| "description": "Non Sim Device Solution (NSDS) needed for VoLTE and VoWifi (Wifi Calling) if you have a virtual SIM. Enabled in devices without esims for some reason. Not sure if there are non-esim virtual sims? \nSee com.sec.vsimservice\nUses IMS service\n", | |
| "description": "Non Sim Device Solution (NSDS) needed for VoLTE and VoWifi (Wifi Calling) if you have a virtual SIM. Enabled in devices without esims for some reason. Not sure if there are non-esim virtual sims?\nSee com.sec.vsimservice\nUses IMS service.", |
| @@ -25389,7 +25389,7 @@ | |||
| "labels": [] | |||
| }, | |||
| "com.samsung.android.brightnessbackupservice": { | |||
| "description": "Backup brightness configuration\nNot sure if it's for powersaving.", | |||
| "description": "Backup brightness configuration\n May be used when reverting the brightness from a mode, routine, or powersaving mode", | |||
There was a problem hiding this comment.
Suggested change
| "description": "Backup brightness configuration\n May be used when reverting the brightness from a mode, routine, or powersaving mode", | |
| "description": "Backup brightness configuration\nMay be used when reverting the brightness from a mode, routine, or powersaving mode", |
| @@ -29625,7 +29625,7 @@ | |||
| }, | |||
| "com.android.phone": { | |||
| "list": "Aosp", | |||
| "description": "AOSP Dialer\nRemoving this package breaks the software update/download and install screen on Samsung", | |||
| "description": "AOSP Dialer\nRemoving this package breaks the software update/download and install screen on Samsung WARNING: for me, it breaks the phone app completely with call routing enabled. not sure about other cases", | |||
There was a problem hiding this comment.
Suggested change
| "description": "AOSP Dialer\nRemoving this package breaks the software update/download and install screen on Samsung WARNING: for me, it breaks the phone app completely with call routing enabled. not sure about other cases", | |
| "description": "AOSP Dialer\nRemoving this package breaks the software update/download and install screen on Samsung. WARNING: for me, it breaks the phone app completely with call routing enabled. not sure about other cases", |
| @@ -31389,7 +31389,7 @@ | |||
| }, | |||
| "com.samsung.android.cidmanager": { | |||
| "list": "Oem", | |||
| "description": "In order to ensure that a user’s phone receives the appropriate firmware updates, this app is used to identify the carrier network. In other words - it helps to ensure that the correct country-specific firmware is delivered OTA.", | |||
| "description": "Sets the CSC for the phone depending on the SIM card. This is responsible for forcing you to restart when to activate the so-called features when inserting new SIM card. It may also revert band settings after OTA update in some cases. WARNING: It may be needed to recieve OTA update, currently unknown.", | |||
There was a problem hiding this comment.
Suggested change
| "description": "Sets the CSC for the phone depending on the SIM card. This is responsible for forcing you to restart when to activate the so-called features when inserting new SIM card. It may also revert band settings after OTA update in some cases. WARNING: It may be needed to recieve OTA update, currently unknown.", | |
| "description": "Sets the CSC for the phone depending on the SIM card. This is responsible for forcing you to restart when to activate the so-called features when inserting new SIM card. It may also revert band settings after OTA update in some cases. WARNING: it may be needed to receive OTA updates, currently unknown.", |
AnonymousWP
changed the title
|
Ok suggestions accepted |
You did not. Suggestions are still open. You need to commit each suggestion manually as GitHub can't commit suggestions in this case due to the large file size. |
|
@arukateru Please follow-up on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.