Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wasmjs GitHub pages #32

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Feature/wasmjs GitHub pages #32

merged 2 commits into from
Aug 19, 2024

Conversation

tonelli-m
Copy link
Collaborator

Description

Fixes (hopefully) GitHub pages deployment by adapting the workflow for the new WasmJS target

Changes

  • Updated gradle task used to build production executable
  • Updated artifacts paths
  • Updated build cache paths
  • Removed reference to appyx branch from this script

Linked issues

Remaining TODOs

N/A

Checklist

  • Code compiles correctly on all platforms
  • All pre-existing tests are passing
  • If needed, new tests have been added
  • Extended the README / documentation if necessary
  • Added code has been documented

@tonelli-m tonelli-m added the KMP Shared Kotlin code label Jul 29, 2024
@nicolas-f
Copy link
Member

Hello, there is issue with compose/coroutines changes that stop the website from collecting audio samples after a while or after resizing.

@nicolas-f
Copy link
Member

image

@tonelli-m
Copy link
Collaborator Author

Hello, there is issue with compose/coroutines changes that stop the website from collecting audio samples after a while or after resizing.

Good catch, although I think this is more part of this issue's scope: #26

This PR is just about updating the GitHub actions workflow to build the WasmJS executable instead of the old one

@tonelli-m tonelli-m changed the base branch from main to dev August 13, 2024 08:30
@nicolas-f nicolas-f merged commit 85244cf into dev Aug 19, 2024
11 of 12 checks passed
@nicolas-f nicolas-f deleted the feature/wasmjs-github-pages branch August 21, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
KMP Shared Kotlin code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants